feat(react-query): add cli error handling #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People can be co-author:
|
🦋 Changeset detectedLatest commit: 6b7f53f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 69 kB ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 75.81% 75.63% -0.19%
==========================================
Files 69 70 +1
Lines 583 591 +8
Branches 128 129 +1
==========================================
+ Hits 442 447 +5
- Misses 130 132 +2
- Partials 11 12 +1
|
gwansikk
commented
Dec 11, 2024
Comment on lines
+3
to
+6
| export const logger = { | ||
| log: (message: string) => console.log(LOG_PREFIX, message), | ||
| error: (message: string) => console.error(LOG_PREFIX, message), | ||
| } |
There was a problem hiding this comment.
All CLI logs are handled through the logger
Comment on lines
+40
to
+46
| try { | ||
| program.parse(process.argv) | ||
| } catch (error) { | ||
| if (error instanceof Error) { | ||
| logger.error(error.message) | ||
| } | ||
| } |
There was a problem hiding this comment.
All throw Errors occurring during the CLI process are handled by the designated error boundary
manudeli
added a commit
that referenced
this pull request
Dec 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @suspensive/[email protected] ### Patch Changes - [#1388](#1388) [`a9bff19`](a9bff19) Thanks [@gwansikk](https://github.com/gwansikk)! - feat(react-query): add cli error handling - Updated dependencies \[]: - @suspensive/[email protected] - @suspensive/[email protected] - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] ## @suspensive/[email protected] ### Patch Changes - Updated dependencies \[]: - @suspensive/[email protected] ## @suspensive/[email protected] ## @suspensive/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
related: #1383 (comment)
ref: https://github.com/tj/commander.js?tab=readme-ov-file#override-exit-and-output-handling
PR Checklist